Login page acceptance tests #7
Merged
+1,132
−263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added acceptance testing for the login page feature using cucumber and puppeteer. Test script has been changed to run Jest tests followed by Cucumber features. .githooks was also modified to run the test script on pre-commit so that no code should be committed with failing tests.
Updated login-page so it doesn't crash the app with a missing user in the database.
|
Also updated the login page to use the new getUser methods (handles EntityNotFound) |
ricardob
approved these changes
Nov 29, 2019
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some acceptance tests for the login page
This addresses #5